KeyframeSelection: Add new parameter value to disable the export of keyframes #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
changed the title
fabiencastan
reviewed
Jun 6, 2023
…none` Add the support for a `none` value for the output extension value. If this value is provided, the selected keyframes will not be written on disk at the end of the process. Only the SfMData files (one containing the keyframes, one containing the frames that were not selected) will be generated. In the case of video inputs, which already only produce the SfMData file containing the keyframes, setting the output extension to `none` will lead to no output at all, since the keyframes' SfMData file needs them to be written on disk. The README is also updated with that information.
…ension Add the support of the `none` value for the output extension parameter. The provided output extension is also lowercased before being compared with the list of supported values. The documentation for the `outputExtension` parameter is updated accordingly.
cbentejac
force-pushed
the
dev/noKeyframeExport
branch
from
030aeb9
to
9125de5
Compare
mugulmd
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Meshroom pull request: alicevision/Meshroom#2036
This PR adds a new supported value to the
outputExtensionparameter,none, that disables the export of selected keyframes on disk when it is set.Up until now, the selected keyframes were always written on disk at the same time as the SfMData files, and there was no way to avoid this. By setting
outputExtensiontonone, only the two SfMData files (one containing the selected keyframes, one containing the frames that were not selected) will be written.Not writing the selected keyframes on disk results in a slight performance improvement as less I/O operations are performed.
Note:
outputExtensionshould not be set tononewhen the input is a video: since the frames from the video are not available on disk, the process expects the keyframes to be written in the output folder to be able to write at least the SfMData file containing the selected keyframes.Features list
outputExtensionthat disables the export of keyframes;