Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed separator in CMAKE_INSTALL_RPATH #1427

Merged
merged 1 commit into from
May 24, 2023

Conversation

serguei-k
Copy link
Contributor

Description

Running commands on OSX when AliceVision was installed into a custom prefix was failing as the command could not find the linked dynamic libraries (because the LC_RPATH was set to path @loader_path/../lib:@loader_path).

The issues is that the CMAKE_INSTALL_RPATH list used a colon as a separator for the path list, instead of a semicolon.

For reference:
https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_RPATH.html

Features list

  • Fix CMAKE_INSTALL_RPATH value

@fabiencastan fabiencastan added this to the 3.1.0 milestone May 24, 2023
@fabiencastan
Copy link
Member

@serguei-k Thanks for the fix! And sorry for the delay to merge it.

@fabiencastan fabiencastan merged commit f7e94a8 into alicevision:develop May 24, 2023
@fabiencastan
Copy link
Member

Hi @serguei-k,
If you have a bit of time and motivation :), it would be really helpful if you could make a PR with some documentation for the macos build.
And hopefully one day, we could setup the macos build in the github action!
Cheers,

@serguei-k
Copy link
Contributor Author

Hi @serguei-k, If you have a bit of time and motivation :), it would be really helpful if you could make a PR with some documentation for the macos build. And hopefully one day, we could setup the macos build in the github action! Cheers,

Hi @fabiencastan, I will give it a shot when I find some time.
vcpkg actually gets you 90% there, clp package wasn't working for some reason so I had to build Clp, CoinUtils and Osi manually. But this is something that probably could be resolved.
Using OpenMP on macos is not straight forward as it does not ship with clang anymore and I had trouble getting it to pick up external installation everywhere.
I am going to build on arch64 at some point too so that should be more interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants