Fix command line parsing for executables that used the old one #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`main_cameraCalibration` has been clang-formatted to use indentation with 4 spaces instead of 2.
…sing The parsing of the command line is now handled in another module and the `aliceVision::CmdLine` object can be used for the command line. This automatically adds the support for the memory- and core-related options. Additionally, this commit updates some of the parameters' descriptions and logs, as well as error handling.
This commit updates the following samples with the factorized command line parsing from the cmdline module: - FeaturesRepeatability - ImageDescriberMatches - RobustFundamental - KvldFilter - RobustFundamentalF10 - HomographyGrowing - SensorWidthDatabase - Texturing - UndistoBrown
Remove samples that are outdated and based on AliceVision classes that do not exist anymore, and thus cannot be compiled anymore.
mugulmd
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the command line parsing of some software and sample executables that were not included in #1302 and #1303 and, as a consequence, cannot be correctly run anymore.
This includes:
CameraCalibrationVoctreeQueryUtilityFeaturesRepeatabilityImageDescriberMatchesRobustFundamentalKvldFilterRobustFundamentalF10HomographyGrowingSensorWidthDatabaseTexturingUndistoBrownAdditionally, all the files whose command line parsing needed to be fixed had, when applicable, their 2-space indentation converted to a 4-space one.
Features list