Distortion calibration #1415
Merged
Distortion calibration #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mugulmd
force-pushed
the
mug/undistortionCalibration
branch
from
869dc24
to
51c0916
Compare
cbentejac
force-pushed
the
mug/undistortionCalibration
branch
2 times, most recently
from
4dc7077
to
e2ebda8
Compare
cbentejac
previously approved these changes
May 24, 2023
…only work for anamorphic4 cameras atm)
…bject instead of a distortion object
…ions and undistortion
This commit drops the changes that were made to `main_exportAnimatedCamera` in the previous commits, except for the cosmetic changes and, in particular, the 4-space indentation. These changes need to be dropped as they are not meant to be added with the distortion calibration, and may cause errors when exporting the animated cameras for which the distortion was calibrated. It additionally harmonizes the comments in the code.
cbentejac
force-pushed
the
mug/undistortionCalibration
branch
from
e2ebda8
to
5c14872
Compare
cbentejac
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to provide new tools and workflows for distortion calibration, and for integrating the calibration in reconstruction pipelines.
The new distortion calibration method - cherry-picked from this PR - builds on top of the checkerboard detection software and uses an undistortion model introduced in 3DEqualizer (the Standard Anamorphic4 model).
Since 3DEqualizer's undistortion models can be used in Nuke, we also created an export software to dump the calibration results in the form of an STMaps couple and a Nuke LensDistortion node.
For integrating a calibrated distortion in a reconstruction pipeline, another software has been added for applying the distortion to an exisiting SfMData's intrinsics. Also, calibrated distortion is now taken into account during bundle adjustments.
Corresponding Meshroom PR: alicevision/Meshroom#1986
Features list
Implementation remarks
This PR was also an opportunity to clean up and uniformize code in the
aliceVision::cameramodule with some cosmetic changes (e.g. 4 space indent).One important change in that regard is that previously this module was header-only, hence several cpp files have been added and most methods have been moved in them.