Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when output extension is missing in image processing #1395

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

demoulinv
Copy link
Contributor

Description

Set ".exr" as default output extension if input image is in a raw file format in imageProcessing.

Replace some INFOs with TRACEs in read image.

Features list

Implementation remarks

Replace INFO with TRACE in read image for displaying camera neutral data in log.
imageProcessing: Set ".exr" as default extension if input image is in a raw file format. Avoid crash when the extension option is empty and a raw image is read.
@demoulinv demoulinv changed the title Fix/extension missing in image processing Fix crash when output extension is missing in image processing Mar 24, 2023
Copy link
Contributor

@cbentejac cbentejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on single images and folders, both with RAW and non-RAW images, and everything works as expected.

@fabiencastan fabiencastan added this to the 3.0.0 milestone Mar 27, 2023
@fabiencastan fabiencastan merged commit d09aeae into develop Mar 27, 2023
@fabiencastan fabiencastan deleted the fix/extensionMissingInImageProcessing branch March 27, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants