[panorama] compositing common scale selection #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/commonScale
branch
from
615752e
to
979d507
Compare
The Gaussian filter window used to be of size (1 + 2 * 2), with 2 the radius of said Gaussian filter. With the change of the common scale from the min scale to the max scale, it is updated to 1, but we might still want to go back to the previous one later on. The const variable gaussianFilterRadius is commented out since it is not used anymore, but might be again in the future.
servantftechnicolor
force-pushed
the
dev/commonScale
branch
from
fdbff0b
to
615752e
Compare
cbentejac
force-pushed
the
dev/commonScale
branch
from
615752e
to
fdbff0b
Compare
cbentejac
approved these changes
Mar 29, 2023
fabiencastan
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the common scale selection for the various chunks.
I replaced min scale with max scale as the common scale for the laplacian compositing.