Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utils] split360Images: support SfMData input and output #1382

Merged
merged 8 commits into from
Jun 3, 2023
Merged

[utils] split360Images: support SfMData input and output #1382

merged 8 commits into from
Jun 3, 2023

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Mar 16, 2023 •
edited
Loading

Description

The goal of this PR is to add support for using SfMData files for the input and output of the aliceVision_split360Images software.

Corresponding Meshroom PR: alicevision/Meshroom#1939

Implementation remarks

The output SfMData file created by aliceVision_split360Images has the following characteristics:

  • all views belong to the same rig
  • this rig's ID is 0
  • all views share the same intrinsic
  • this intrinsic's ID is 0
  • the camera model for the intrinsic is radial3 for equirectangular split and either fisheye4 or equidistant_r3 for dual fisheye (user choice)
  • the intrinsic's sensor size is always 36mm x 36mm
  • in dual fisheye mode, if no focal metadata is found, an initial guess on the field of view if made with the value 170 degrees.

@mugulmd mugulmd self-assigned this Mar 16, 2023
@mugulmd mugulmd mentioned this pull request Mar 16, 2023
Merged
@mugulmd mugulmd marked this pull request as ready for review March 20, 2023 15:19
@fabiencastan fabiencastan added this to the 3.1.0 milestone May 10, 2023
fabiencastan
fabiencastan previously requested changes May 10, 2023
View reviewed changes
Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails

@fabiencastan fabiencastan merged commit ba78f38 into develop Jun 3, 2023
@fabiencastan fabiencastan deleted the mug/split360WithSfM branch June 3, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

@servantftechnicolor servantftechnicolor Awaiting requested review from servantftechnicolor

Assignees

@mugulmd mugulmd

Labels
majorFeature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mugulmd @fabiencastan