Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stitching color space #1380

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Stitching color space #1380

merged 5 commits into from
Jun 12, 2023

Conversation

demoulinv
Copy link
Contributor

Description

Enable color space selection at stitching level.

Features list

  • Add working color space option for feature extraction instead of forcing sRGB.
  • Add output color space option at warping instead of forcing linearwith sRGB primaries. The selected color space will be used for the stitching.
  • Update compositing to enable using other color spaces than linear with sRGB primaries.
  • If dcpMetadata is selected as raw color processing at HDR merge then read image without white balancing before demosaicing.

Implementation remarks

@fabiencastan fabiencastan added this to the 3.0.0 milestone Mar 17, 2023
@fabiencastan fabiencastan marked this pull request as draft March 18, 2023 13:57
@fabiencastan fabiencastan modified the milestones: 3.0.0, 3.0.1 Mar 20, 2023
@fabiencastan fabiencastan modified the milestones: 3.2.0, 3.1.0 Apr 3, 2023
@demoulinv demoulinv marked this pull request as ready for review April 13, 2023 05:56
@cbentejac cbentejac self-requested a review June 9, 2023 14:11
@cbentejac cbentejac mentioned this pull request Jun 9, 2023
Merged
3 tasks
@demoulinv @cbentejac
[FeatureExtraction] Add working color space
d6eb291
@demoulinv @cbentejac
[panoramaWarping] Add output color space option
aeb7c2e
@demoulinv @cbentejac
[HDR Merge & compositing]
a1ec8d5 
HDR Merge: Add color space in output view.
           If dcpMetadata as raw color interpretation disable WB before demosaicing to get real raw images.
Compositing: Add source color space when writing panorama image to support other color space than Linear as source.
@demoulinv @cbentejac
[panoramaWarping & HDR merge]
8bf3b88 
panoramaWarping: Rename outputColorSpace in workingColorSpace.
HDR merge: Add comments.
@cbentejac cbentejac merged commit d184b25 into develop Jun 12, 2023
@cbentejac cbentejac deleted the dev/stitchingColorSpace branch June 12, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@servantftechnicolor servantftechnicolor servantftechnicolor left review comments

@fabiencastan fabiencastan fabiencastan left review comments

@cbentejac cbentejac cbentejac approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@demoulinv @fabiencastan @cbentejac @servantftechnicolor