-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views ancestors for hdr #1337
Merged
Merged
Views ancestors for hdr #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
requested changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move localBA commit in a separate PR.
servantftechnicolor
force-pushed
the
dev/hdrHistory
branch
from
January 20, 2023 05:09
873ea02
to
764dae8
Compare
It would be good to increment the minor version for ABC, SFM formats, if we ever need to identify this version. |
servantftechnicolor
force-pushed
the
dev/hdrHistory
branch
from
January 20, 2023 08:47
fac3a34
to
c2fd9f7
Compare
fabiencastan
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each view has now a list of ancestor views. It is an array of IndexT which are the views (may not exist anymore in this sfmData) from which the current view was created. For example a HDR view may have all the LDR views as its ancestors.