[hdr] Compute the center exposure of the hdr automatically #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
force-pushed
the
dev/hdrMerge_autoRefLevel
branch
3 times, most recently
from
b4c6eb0
to
ce5b808
Compare
cbentejac
previously requested changes
Dec 16, 2022
fabiencastan
changed the title
demoulinv
force-pushed
the
dev/hdrMerge_autoRefLevel
branch
from
a48c327
to
6e2e7cb
Compare
fabiencastan
requested changes
Jan 15, 2023
demoulinv
force-pushed
the
dev/hdrMerge_autoRefLevel
branch
from
6e2e7cb
to
659717c
Compare
Use samples in calibration node to determine the reference exposure for each grouped views. Write results in a text file in the same directory as the response file. In the merge node, read the file containing the reference indexes and use them to compute the HDR image.
…ode refactoring. LdrToHdrMerging: Use offsetRefBracketIndex parameter if it is in a suitable range regarding the number of views in a group. If not, use the indexes computed in the calibration node.
code simplification Co-authored-by: Fabien Castan <[email protected]>
Remove useless ofstream closing
Compute reference index for merging within the merging node after reading luminance statistics provided by the calibration node through a text file.
Manage bypass mode by computing luminance statistics from images at the calibration stage. Adjust the targeted luminance level for the output HDR image in case of non sRGB working space.
Code adjustment and cleaning.
Add bypass and calibrationMethod as parameters of sampling.cpp. Move calibration method definition in brackets.hpp. Redispatch luminance statistics computation between sampling and calib. Create a simplified sampling mode. Update luminance statistics file format.
make sure the luminance stat curve is monotonic before searching the best exposure.
demoulinv
force-pushed
the
dev/hdrMerge_autoRefLevel
branch
from
3207c9a
to
b3e8a8e
Compare
…ror if non consistent group of exposures are detected.
fabiencastan
reviewed
Feb 7, 2023
fabiencastan
reviewed
Feb 7, 2023
Accept unaligned exposures between poses. Add origin viewID in image samples.
Remove monotonicity check of the mean luminance curve. Such a check is done for every poses when the luminance statistic file is built.
Comment on lines
+443
to
+451
| double exposureMin = 1e9; | ||
| for (auto it = v_luminanceInfos[i].begin(); it != v_luminanceInfos[i].end(); it++) | ||
| { | ||
| if ((it->second).exposure < exposureMin) | ||
| { | ||
| exposureMin = (it->second).exposure; | ||
| srcIdWithMinimalExposure = it->first; | ||
| } | ||
| } |
There was a problem hiding this comment.
It would be better to sort the data before file export.
fabiencastan
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use samples in calibration node to determine the reference exposure for each grouped views. Write results in a text file in the same directory as the response file. In the merge node, read the file containing the reference indexes and use them to compute the HDR image.
Description
In the calibration node, for all exposure levels of each group of views, the mean, max an min values of luminance are computed from all the mean rgb info contained in the loaded image samples. For each group of views, the index of the reference image is deduced from those stats. The average of those computed indexes is written in a text file located in the same directory as the response file already delivered by the node.
In the merging node, the file is read and the index is used to build the HDR image. A parameter is still there to overide the automaticaly set ref images if needed.
Features list
Implementation remarks