Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfmColorHarmonize] update selection method enum and command-line argument #1306

Merged
merged 4 commits into from
Nov 30, 2022
Merged

[sfmColorHarmonize] update selection method enum and command-line argument #1306

merged 4 commits into from
Nov 30, 2022

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Nov 18, 2022

Description

In this PR we update the enum system used for the selectionMethod argument of sfmColorHarmonize to use an enum class that works the same way as other aliceVision executables instead.

@mugulmd mugulmd self-assigned this Nov 18, 2022
fabiencastan
fabiencastan requested changes Nov 24, 2022
View reviewed changes
Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing description of the option

@fabiencastan fabiencastan added this to the 2.5.0 milestone Nov 24, 2022
@fabiencastan fabiencastan merged commit 7cc839f into develop Nov 30, 2022
@fabiencastan fabiencastan deleted the mug/colorHarmonize/selectionMethodEnum branch November 30, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees

@mugulmd mugulmd

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mugulmd @fabiencastan