Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DepthMap] Depth map improvements #1296

Merged
merged 238 commits into from
Jan 22, 2023
Merged

[DepthMap] Depth map improvements #1296

merged 238 commits into from
Jan 22, 2023

Conversation

gregoire-dl
Copy link
Member

@gregoire-dl gregoire-dl commented Nov 7, 2022 •
edited
Loading

The objective of this PR is to compute depth/similarity map per tile using one CUDA stream per tile.

Related Meshroom branch: alicevision/Meshroom#1818

Features list

  • Remove legacy Refine strategy.
  • Remove DepthSimMap class
  • Use a CUDA kernel to upscale a depth/similarity map.
  • Use a CUDA kernel to compute pixSize from a depth/similarity map.
  • Use fixed allocations for Sgm & Refine objects
  • User options for Refine scale and step parameters
  • Use half image texture and half volume (for Refine)
  • Refactoring of Sgm depth list calculation
  • Add tilling strategy

Implementation remarks

This PR must be tested intensively before being merged.
Tests must include a multi-GPU test.

@gregoire-dl @p12tic
[depthMap] Reorganization of gpu cache
74d9550 
- Cut PlaneSweepingCuda gpu cache into multiple classes
- Remove gpu pyramid frame cache
- Add DeviceCamera to manage device memory (frame, parameters) of a given camera at a given downscale
- Add DeviceCache to manage per device a LRU of DeviceCamera
- Add utils functions for widely used cuda operations
- Uniformization of some variable names in the whole CUDA module
- Add cudaSetDevice in computeOnMultiGPUs GPUJobs functions
@gregoire-dl @p12tic
[depthMap] Rename commonStructures to memory
65bd130
@gregoire-dl @p12tic
[depthMap] Remove redundant variables
da39a91
@gregoire-dl @p12tic
[depthMap] Add CudaROI struct
f87e347
@gregoire-dl @p12tic
[depthMap] Remove plane_sweeping_cuda
ff2ce96
@gregoire-dl @p12tic
[depthMap] CUDA file reorganisation
afb2468
@gregoire-dl @p12tic
[depthMap] Remove MultiViewParams and ImagesCache dependencies in Dev…
14a12a7 
…iceCamera
@gregoire-dl @p12tic
[depthMap] Remove CudaROI
8645e2a
@gregoire-dl @p12tic
[depthMap] Add new ROI struct
3ea8ec1
@gregoire-dl @p12tic
[depthMap] hostUtils: Remove tic / toc
c27d5ae
@gregoire-dl @p12tic
[depthMap] ROI: Remove useless checks
0a4edd4
@gregoire-dl @p12tic
[depthMap] Sgm: Add ROI to cuda_volumeComputeSimilarity
3ab8420 
Remove OneTC
@gregoire-dl @p12tic
[depthMap] Sgm: Add ROI to cuda_volumeRetrieveBestDepth
25e4dee
@gregoire-dl @p12tic
[depthMap] Sgm: New CUDA function cuda_volumeOptimize
fdb559b
@gregoire-dl @p12tic
[depthMap] ROI: Fix type comparison
d4f81be
@gregoire-dl @p12tic
[depthMap] planeSweeping: Add doc
e113f89
@gregoire-dl @p12tic
[depthMap] Add DeviceStreamManager
2106552
@gregoire-dl @p12tic
[depthMap] deviceSimilarityVolumeKernels: Fix unused value parameter
8173caf
@gregoire-dl @p12tic
[depthMap] DepthSimMap: Add accessors
1ffba2c
@gregoire-dl @p12tic
[depthMap] Refine: Add ROIs and remove unnecessary host/device memory…
c6598dd 
… copies
@gregoire-dl @p12tic
[depthMap] Remove class PlansSweepingCuda
c72cd4f
@gregoire-dl @p12tic
[depthMap] Cuda: compNCCby3DptsYK refactoring
26a3e0f
@gregoire-dl @p12tic
[depthMap] planeSweeping: Add TSimRefine definition
121235b
@gregoire-dl @p12tic
[depthMap] imageProcessing: Add volume gaussian smoothing functions
1137270
@gregoire-dl @p12tic
[depthMap] RefineParams: Add volume strategy parameters
03131e2
@gregoire-dl @p12tic
[depthMap] volumeIO: Add volume cross export / Add documentation
720c9bb
@gregoire-dl @p12tic
[depthMap] Sgm: Fix optimized volume export
581edcf
@gregoire-dl @p12tic
[depthMap] Refine: Add volume strategy
a96d003
@gregoire-dl @p12tic
[depthMap] Refine: Fix some cast
650ff5d
@gregoire-dl @p12tic
[depthMap] RefineParams: By default do not use the volume strategy
299ad8b
@fabiencastan fabiencastan added this to the 2.5.0 milestone Jan 10, 2023
fabiencastan
fabiencastan previously approved these changes Jan 10, 2023
View reviewed changes
@gregoire-dl
[mvsUtils] Tiling: Fix typo
19aa523
@gregoire-dl
[depthMap] Tiling: Fix typo
697be8a
@gregoire-dl
[depthMap] SgmDepthList: Remove maxDepthsPerTc parameter
c3e94f9
@gregoire-dl
[depthMap] RefineParams: Rename useRefineFuse & useColorOptimization
06f1ee1
@gregoire-dl
[software] depthMapEstimation: Update GammaC & GammaP descriptions
f7fe269
@gregoire-dl
[software] depthMapEstimation: Remove useless parameter check
684cadb
@gregoire-dl
[software] depthMapEstimation: Update command-line parameters descrip…
f086910 
…tions
@gregoire-dl
[depthMap] RefineParams: Rename optimizationNbIterations parameter
b880950 
Also add software parameter description
@gregoire-dl
[depthMap] RefineParams: Change parameter name and logic for refineHa…
a8798d5 
…lfNbDepths & refineSubsampling
@gregoire-dl
[depthMap] SgmParams: Rename depthListPerTile parameter
cfd2342
@gregoire-dl
[depthMap] Refine: Add information logs
4c91907
@gregoire-dl
[depthMap] Cuda: deviceSimilarityVolume: Impove variable name unifomity
9ffe937
@gregoire-dl
[depthMap] Cuda: deviceDepthSimilarityMap: Impove variable name unifo…
cb5d614 
…mity
@fabiencastan fabiencastan merged commit 648cee8 into develop Jan 22, 2023
@fabiencastan fabiencastan deleted the dev/depthMapImprovements branch January 22, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
CUDA refactoring review type:pr
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gregoire-dl @fabiencastan