Resurrect hdr test #1276
Merged
Resurrect hdr test #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe good also to use lowerCamelCase for filenames for consistency. |
p12tic
force-pushed
the
resurrect-hdr-test
branch
from
dcdaab6
to
a9aae95
Compare
|
@fabiencastan I've addressed your comments. |
p12tic
force-pushed
the
resurrect-hdr-test
branch
from
a9aae95
to
562b58f
Compare
extractSamplesGroups has been resurrected from 7b1ace3 where it was deleted.
Currently HDR test is one of the longest running tests at ~120 seconds on AMD 2990WX. Splitting it up reduces test runtime in cases testsuite is run in parallel.
p12tic
force-pushed
the
resurrect-hdr-test
branch
from
562b58f
to
a9d6148
Compare
|
@fabiencastan I've addressed your comment. |
fabiencastan
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hdrhas been disabled in 5994701 and bitrot a bit since. This PR resurrects the test. A bit of digging into history was needed (e.g. takingextractSamplesGroupsfrom 7b1ace3), but in the end the test completes successfully.The test takes a while to run, so it has been split into multiple executables just like sfm_panorama test in #1272.