(trivial) Extract some code out of pipeline executables to reusable modules #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the class to be reused by other components.
This allows the code to be reused by other components.
This allows the code to be reused by other components.
fabiencastan
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR moves code out of pipeline executables to aliceVision libraries that can be linked into other executables which in turn allows code reuse.
Aside from re-indentation to 4-space indents and several wrapped long lines the PR just moves code around.
This PR is related to #1208, but since that PR has not received much attention (understandably, because that PR is relatively complex), we're upstreaming our interim solution which is much simpler, less risky and should be easier to get in.