Don't use deprecated filesystem copy options #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users will either use system Boost, which is 1.74 on both Debian stable (bullseye) and Ubuntu 22.04 LTS, or compile from source on older systems or RHEL which already has older Boost anyway. Therefore bumping the requirement is harmless.
The new API has been introduced in Boost 1.74 and follows C++17 more closely.
fabiencastan
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces usage of
boost::filesystem::copy_optionsinstead of deprecated equivalent.The new API has been introduced in Boost 1.74 and follows C++17 more closely.
Boost dependency has been bumped to 1.74. This is harmless because users will either use system Boost, which is 1.74 on both Debian stable (bullseye) and Ubuntu 22.04 LTS, or compile from source on older systems or RHEL which already has older Boost anyway. Therefore bumping the requirement is harmless.
I don't think we should upgrade to even newer boost because this would force even more libraries to be recompiled from source and included into AliceVision install prefix when developing even on relatively new systems.