Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong integer division where rounding up was intended #1254

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Fix wrong integer division where rounding up was intended #1254

merged 2 commits into from
Oct 6, 2022

Commits on Oct 6, 2022

  1. [numeric] Introduce divideRoundUp() for integer division with rounding

    @p12tic
    p12tic committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d518966 View commit details
    Browse the repository at this point in the history

  2. [fuseCut] Fix incorrect rounding of integer division result 

    The intention here likely was to get floating-point division result and
round it upwards. However, the division was performed with integer
arguments, fractional part was lost and thus std::ceil did nothing.
    @p12tic
    p12tic committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    2caea25 View commit details
    Browse the repository at this point in the history