(trivial) Avoid repeated calls to std::min() or std::max() #1253

p12tic · 2022-10-01T23:30:14Z

These functions have overloads accepting std::initializer_list argument which does not introduce performance overheads.

simogasp

LGTM
It's always nice to learn new useful things! I didn't know about the overload version with the initializer.

Avoid repeated calls to std::min() or std::max()

74a8b92

These functions have overloads accepting std::initializer_list argument which does not introduce performance overheads.

p12tic changed the title ~~[trivial] Avoid repeated calls to std::min() or std::max()~~ (trivial) Avoid repeated calls to std::min() or std::max() Oct 1, 2022

simogasp approved these changes Oct 2, 2022

View reviewed changes

simogasp added this to the 2.5.0 milestone Oct 2, 2022

simogasp added the type:enhancement label Oct 2, 2022

fabiencastan approved these changes Oct 6, 2022

View reviewed changes

fabiencastan merged commit 8fd9318 into alicevision:develop Oct 6, 2022

p12tic deleted the avoid-repeated-minmax branch October 6, 2022 13:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(trivial) Avoid repeated calls to std::min() or std::max() #1253

(trivial) Avoid repeated calls to std::min() or std::max() #1253

p12tic commented Oct 1, 2022

simogasp left a comment

(trivial) Avoid repeated calls to std::min() or std::max() #1253

(trivial) Avoid repeated calls to std::min() or std::max() #1253

Conversation

p12tic commented Oct 1, 2022

simogasp left a comment

Choose a reason for hiding this comment