-
-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use external CoinUtils, Osi and Clp libraries #1237
Always use external CoinUtils, Osi and Clp libraries #1237
Conversation
[note to self] we will also need to update and upload the docker images as they are used for the ci |
Very cool, this task was in my backlog. Will reduce the rebuild time of alicevision. |
I'm rebuilding the docker image for the dependencies to be able to use it in the linux CI. |
785e53d
to
8ce8bc1
Compare
I've rebased on top of latest |
I get this error when building it with
|
8ce8bc1
to
66c3f98
Compare
@fabiencastan I've fixed the |
We will need to add osi to vcpkg. |
https://github.com/microsoft/vcpkg/tree/master/ports/osi |
@@ -174,6 +174,8 @@ jobs: | |||
ceres[suitesparse,cxsparse] | |||
tbb | |||
assimp | |||
clp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clp will automatically import coinutils
and osi
30d62c8
to
b57c46d
Compare
Missing XX_VERSION variables. |
Co-authored-by: Simone Gasparini <[email protected]>
Previously we used an internal fork of CoinUtils, Osi and Clp libraries that was included as a submodule. The repository structure was significantly different than what upstream has (3 repositories vs. 1 on our side) and thus tracking upstream was harder than necessary.
This PR converts the project to use new forks of upstream CoinUtils, Osi and Clp at https://github.com/alicevision/CoinUtils, https://github.com/alicevision/Osi and https://github.com/alicevision/Clp. These repositories currently have pending PRs with cmake support.