[fuseCut] Pick isnormal() from std namespace #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simogasp
reviewed
Sep 17, 2022
| @@ -1629,7 +1629,7 @@ DelaunayGraphCut::GeometryIntersection DelaunayGraphCut::rayIntersectTriangle(co | |||
| Point3d tempIntersectPt; | |||
| const Point2d triangleUv = getLineTriangleIntersectBarycCoords(&tempIntersectPt, A, B, C, &originPt, &DirVec); | |||
|
|
|||
| if (!isnormal(tempIntersectPt.x) || !isnormal(tempIntersectPt.y) || !isnormal(tempIntersectPt.z)) | |||
| if (!std::isnormal(tempIntersectPt.x) || !std::isnormal(tempIntersectPt.y) || !std::isnormal(tempIntersectPt.z)) | |||
There was a problem hiding this comment.
Shouldn't we also #include <cmath> so that we are sure it is included and thus we do not rely on other includes to import the function?
There was a problem hiding this comment.
I agree. This is fixed now.
This fixes compile error due to isnormal() being not available in the global namespace.
p12tic
force-pushed
the
isnormal-compile-error
branch
from
876fada
to
f160515
Compare
fabiencastan
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes compile error due to isnormal() being not available in the global namespace. Errors like this most often occur because we accidentally rely on what headers the standard library headers include internally.