[CMake] Check AV_EIGEN_MEMORY_ALIGNMENT when building dependencies #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
reviewed
Sep 9, 2022
p12tic
force-pushed
the
dependencies-eigen-alignment
branch
2 times, most recently
from
bf0b617
to
6ddf4b3
Compare
p12tic
changed the title
fabiencastan
previously approved these changes
Sep 11, 2022
|
@p12tic Could you rebase to fix the conflict? |
This way dependencies use the same Eigen alignment settings as AliceVision itself.
p12tic
force-pushed
the
dependencies-eigen-alignment
branch
from
6ddf4b3
to
8135d34
Compare
|
@fabiencastan Rebased, thanks. |
fabiencastan
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up after #1196.