Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sfm] make sure we give other chances to candidates #1200

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

servantftechnicolor
Copy link
Contributor

@servantftechnicolor servantftechnicolor commented Jul 29, 2022

In the incremental SFM, the reconstruction select iteratively some candidates for resection. It may happens that this selection is not good and the resection fail. In this case, the frame is definitely discarded. This PR gives them other chances to shine !

  • If a resection fail, the frame id is not removed from the set of available frames.
  • To make sure we don't retry at each iteration those frames, we estimate at each iteration which frames are affected by the changes on the reconstruction in the current iteration. For all frames which have been newly inserted into the reconstruction, trigger the connected frames (through tracks) for the next iteration.

@fabiencastan fabiencastan added this to the 2.5.0 milestone Oct 18, 2022
fabiencastan
fabiencastan previously approved these changes Nov 9, 2022
@fabiencastan fabiencastan merged commit 31fbb5f into develop Nov 10, 2022
@fabiencastan fabiencastan deleted the dev/trackingMissingFrames branch November 10, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants