Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to compile Eigen with alignment enabled #1196

Merged

Commits on Aug 29, 2022

  1. Add option to compile Eigen with alignment enabled

    Eigen is most optimal when using SIMD instructions which require
    overaligned buffers. In C++14 this is a problem because there's no
    built-in support for correctly aligned allocations, so this Eigen
    feature is currently disabled in AliceVision. C++17 solves Eigen
    alignment issues completely because there now exist additional overloads
    of operator new() which support correct allocation alignment. We can't
    upgrade to C++17 yet, but certain compilers added support for this
    feature earlier, such as -faligned-new in GCC 7.1. Therefore it makes
    sense to add a configuration option to allow enabling alignment support
    in Eigen in cases when the compiler is good enough.
    p12tic committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4ae2ff6 View commit details
    Browse the repository at this point in the history