Remove uses of fscanf #1190
Merged
Remove uses of fscanf #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C99 specifies that numeric overflow when reading numbers in fscanf leads to undefined behavior. Which menas that malformed input is allowed to crash the program. iostreams do not have this problem since C++11.
C99 specifies that numeric overflow when reading numbers in fscanf leads to undefined behavior. Which menas that malformed input is allowed to crash the program. iostreams do not have this problem since C++11.
|
Windows CI is failing due to network problems. |
fabiencastan
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several uses of C fscanf functionality. Using it directly is unsafe because numeric overflow yields undefined behavior which may crash the program in the worst case. Using C++ equivalents is less problematic, because numeric overflow is well defined there.
A test for changed serialization implementations has been added where possible. A couple of small fixes needed for tests are also included into the PR.