Output color space in ACES or ACEScg #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
changed the title
simogasp
reviewed
Apr 26, 2022
simogasp
reviewed
Apr 26, 2022
simogasp
reviewed
Apr 26, 2022
simogasp
reviewed
Apr 26, 2022
|
Maybe good to add ALICEVISION_ROOT at the end of the docker environment too: |
simogasp
reviewed
Apr 26, 2022
* Update FindOpenImageIO.cmake adding OpenImageIO_Util library * Update AliceVisionConfig.cmake.in adding Alembic dependancy * Add config.ocio file and update cmake file for installation * OCIO usage for output in ACES or ACEScg color space
…onfig.ocio and cameraSensors.db files. In main_cameraInit.cpp, filepath to access cameraSensors.db becomes an optional parameter. If not specified, try to access the default file with filepath $ALICEVISION_ROOT/share/aliceVision/cameraSensors.db src/CMakeLists.txt : Limit some Boost def to Windows. Remove definition of config.ocio filepath in cmake file.
Co-authored-by: Simone Gasparini <[email protected]>
Co-authored-by: Simone Gasparini <[email protected]>
…not existing. Update Docker files with new environment variable ALICEVISION_ROOT. Code cleaning.
demoulinv
force-pushed
the
dev/feature_OutputInACEScgColorSpace
branch
from
35ae71f
to
f0fd559
Compare
Update environment variable definition ALICEVISION_ROOT Bugfix in Docker ubuntu version
Avoid ACES or ACEScg conversion if NO_CONVERSION is specified for output color space.
fabiencastan
approved these changes
Apr 27, 2022
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable writing images in ACES and ACEScg color space in main_imageProcessing.
Features list
OCIO config file support added but cannot be selected by the end user. Default file set at installation.
Parameter sensorDatabase not anymore a required parameter in main_cameraInit.
Boost settings updated to enable error free compilation when using Boost through vcpkg on Windows.
Add Alembic dependancy in AliceVisionConfig.cmake.in.
Implementation remarks
OCIO config file accessed in io.cpp through the environment variable ALICEVISION_ROOT to be defined when using AliceVision.
The same variable is used in main_cameraInit.cpp to access cameraSensors.db if the file path is not given as a parameter.
Enum to string for EImageColorSpace in order to use them as parameter in main_imageProcessing.cpp