Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hdr] new ExposureSetting class #1165

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[hdr] new ExposureSetting class #1165

merged 1 commit into from
Apr 21, 2022

Conversation

fabiencastan
Copy link
Member

  • use double instead of float
  • check if exposures are comparable: hasComparableExposures

@fabiencastan fabiencastan added this to the 2.5.0 milestone Apr 4, 2022
servantftechnicolor
servantftechnicolor requested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@servantftechnicolor servantftechnicolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me except the float for maxvariance

src/aliceVision/hdr/sampling.cpp Outdated Show resolved Hide resolved
@fabiencastan
[hdr] new ExposureSetting class
a9f5d53 
- use double instead of float
- check if exposures are comparable: hasComparableExposures
@fabiencastan fabiencastan merged commit 7216d61 into develop Apr 21, 2022
@fabiencastan fabiencastan deleted the fix/exposure branch April 21, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@servantftechnicolor servantftechnicolor servantftechnicolor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiencastan @servantftechnicolor