Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Move to C++14 #1080

Merged
merged 6 commits into from
Jul 22, 2021
Merged

[cmake] Move to C++14 #1080

merged 6 commits into from
Jul 22, 2021

Conversation

fabiencastan
Copy link
Member

Supports for C++14 requires:

  • NVCC cuda version >= 9.0
  • GCC >= 5
  • MSVC >= 19.10

https://en.cppreference.com/w/cpp/compiler_support

@fabiencastan
[cmake] Move to C++14
089435f 
Supports for C++14 requires:
 - NVCC cuda version >= 9.0
 - GCC >= 5
 - MSVC >= 19.10

https://en.cppreference.com/w/cpp/compiler_support
simogasp
simogasp requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@simogasp simogasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update INSTALL.md with all the references to c++11 and the required version of compilers etc

src/CMakeLists.txt Show resolved Hide resolved
@simogasp simogasp added this to the 2.5.0 milestone Jul 15, 2021
@simogasp
Copy link
Member

and the .clang-format file as well

@simogasp
Copy link
Member

it would be nice now to replace all the unique_ptr call to .reset(new Constructor(p1, p2, ...)) to = make_unique<Class>(p1, p2, ...) 😛

@fabiencastan fabiencastan merged commit b18accb into develop Jul 22, 2021
@fabiencastan fabiencastan deleted the dev/c++14 branch July 22, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simogasp simogasp simogasp requested changes

Assignees
No one assigned
Labels
scope:build
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fabiencastan @simogasp