Skip to content

Commit

Permalink
post-review update
Browse files Browse the repository at this point in the history
add counter for points filtered out (not enough observation)
add info log for total count
add info log for parameter minVis in log header
  • Loading branch information
raphael2692 authored Sep 21, 2020
1 parent 2ce4a31 commit 3eca2c4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/aliceVision/fuseCut/DelaunayGraphCut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -871,12 +871,16 @@ void DelaunayGraphCut::fuseFromDepthMaps(const StaticVector<int>& cams, const Po
verticesCoordsPrepare.resize(realMaxVertices);
std::vector<double> pixSizePrepare(realMaxVertices);
std::vector<float> simScorePrepare(realMaxVertices);

// counter for points filtered based on the number of observations (minVis)
int minVisCounter = 0;

ALICEVISION_LOG_INFO("simFactor: " << params.simFactor);
ALICEVISION_LOG_INFO("nbPixels: " << nbPixels);
ALICEVISION_LOG_INFO("maxVertices: " << params.maxPoints);
ALICEVISION_LOG_INFO("step: " << step);
ALICEVISION_LOG_INFO("realMaxVertices: " << realMaxVertices);
ALICEVISION_LOG_INFO("minVis: " << params.minVis);

ALICEVISION_LOG_INFO("Load depth maps and add points.");
{
Expand Down Expand Up @@ -1081,8 +1085,8 @@ void DelaunayGraphCut::fuseFromDepthMaps(const StaticVector<int>& cams, const Po
// Filter points based on their number of observations
if(visCams.size() < params.minVis)
{
ALICEVISION_LOG_DEBUG("minVis value:" << params.minVis);
pixSizePrepare[vIndex] = -1;
minVisCounter += 1;
continue;
}

Expand All @@ -1102,6 +1106,7 @@ void DelaunayGraphCut::fuseFromDepthMaps(const StaticVector<int>& cams, const Po
ALICEVISION_LOG_INFO("Angle min: " << stat_minAngle << ", max: " << stat_maxAngle << ".");
ALICEVISION_LOG_INFO("Angle score min: " << stat_minAngleScore << ", max: " << stat_maxAngleScore << ".");
#endif
ALICEVISION_LOG_INFO((minVisCounter) << " points filtered based on the number of observations (minVis). ");
removeInvalidPoints(verticesCoordsPrepare, pixSizePrepare, simScorePrepare, verticesAttrPrepare);

ALICEVISION_LOG_INFO("Filter by angle score and sim score");
Expand Down

0 comments on commit 3eca2c4

Please sign in to comment.