Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/autoconfig 2024 #110

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

disaster1-tesk
Copy link
Contributor

Describe what this PR does / why we need it

add autoconfig module

Does this pull request fix one issue?

none

Describe how you did it

add new module and update pom file

Describe how to verify it

add starter dependency and run

Special notes for reviews

pom.xml Outdated
@@ -33,7 +33,8 @@
<modules>
<module>spring-ai-alibaba-core</module>
<module>spring-ai-alibaba-starter</module>
</modules>
<module>spring-ai-alibaba-autoconfig</module>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use autoconfigure, for both the module name and package name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh!,I found the problem and have recommitted to fix it

@disaster1-tesk disaster1-tesk force-pushed the feature/autoconfig-2024 branch from 5b2fc9b to 42965c3 Compare November 19, 2024 03:17
module and pom

:busts_in_silhouette: Add autoconfig module

update pom file

:busts_in_silhouette: Update module name

update autoconfig name

:arrow_up: Update dependency

change autoconfig name

:busts_in_silhouette: Update module name

name change
@disaster1-tesk disaster1-tesk force-pushed the feature/autoconfig-2024 branch from 42965c3 to 4334f83 Compare November 19, 2024 03:18
spring-ai-alibaba-autoconfig -> spring-ai-alibaba-autoconfigure
Copy link
Collaborator

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit afe0afd into alibaba:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants