Skip to content

Conversation

@zhangmingke
Copy link
Contributor

@zhangmingke zhangmingke commented Mar 18, 2020

Describe what this PR does / why we need it

add adapter for echo framework

  • SentinelMiddleware returns new echo.HandlerFunc

  • Default resource name is {method}:{path}, such as "GET:/api/:id"

  • Default block fallback is returning 429 code

  • Define your own behavior by setting options

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added area/integrations Issue related to integrations with open-source components to-review PRs to review labels Mar 18, 2020
@sczyh30
Copy link
Member

sczyh30 commented Mar 18, 2020

Could you please add some description about your design according to the PR template?

@sczyh30
Copy link
Member

sczyh30 commented Mar 19, 2020

And could you please resolve conflicts?

@sczyh30 sczyh30 added this to the 0.3.0 milestone Mar 19, 2020
@codecov-io
Copy link

codecov-io commented Mar 20, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   42.29%   43.03%   +0.73%     
==========================================
  Files          59       61       +2     
  Lines        2480     2512      +32     
==========================================
+ Hits         1049     1081      +32     
  Misses       1311     1311              
  Partials      120      120              
Impacted Files Coverage Δ
adapter/echo/middleware.go 100.00% <100.00%> (ø)
adapter/echo/option.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6388225...5635d9e. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added kind/feature Category issues or PRs related to feature request and removed to-review PRs to review labels Apr 3, 2020
@sczyh30 sczyh30 merged commit 6716dc0 into alibaba:master Apr 3, 2020
@sczyh30
Copy link
Member

sczyh30 commented Apr 3, 2020

Nice work. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/integrations Issue related to integrations with open-source components kind/feature Category issues or PRs related to feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants