-
Notifications
You must be signed in to change notification settings - Fork 448
Add adapter for echo framework #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please add some description about your design according to the PR template? |
|
And could you please resolve conflicts? |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 42.29% 43.03% +0.73%
==========================================
Files 59 61 +2
Lines 2480 2512 +32
==========================================
+ Hits 1049 1081 +32
Misses 1311 1311
Partials 120 120
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Nice work. Thanks for contributing! |
Describe what this PR does / why we need it
add adapter for echo framework
SentinelMiddleware returns new echo.HandlerFunc
Default resource name is {method}:{path}, such as "GET:/api/:id"
Default block fallback is returning 429 code
Define your own behavior by setting options
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews