Dynamic datasource framework init #73
Conversation
louyuting
force-pushed
the
file-data-source
branch
from
f031332 to
8554653
Compare
| if src == nil { | ||
| return nil | ||
| } | ||
| rs := gjson.ParseBytes(src).Array() |
There was a problem hiding this comment.
This is a little problem: what should I do if the data souce is a file in toml format?
| "github.com/tidwall/gjson" | ||
| ) | ||
|
|
||
| func SystemRulesConvert(src []byte) interface{} { |
There was a problem hiding this comment.
[]byte looks a little strange, how about io.Reader?
| return errors.New(fmt.Sprintf("Invalid parameters: data:%+v", data)) | ||
| } | ||
| val, ok := data.([]*system.SystemRule) | ||
| if !ok { |
There was a problem hiding this comment.
Do we need compare the data in cache with the new data like the Java design? Or update the value in cache directly?
| return ds | ||
| } | ||
|
|
||
| func (ds *FileDataSource) listen() { |
There was a problem hiding this comment.
As you add two function for type DataSource interface, all the specific datasource should implement it.
| //} | ||
|
|
||
| func TestNewFileDataSource_SystemRule(t *testing.T) { | ||
| ds := FileDataSourceStarter("../../tests/testdata/extension/refreshable_file/SystemRule.json", ext.NewSystemRulesHandle()) |
There was a problem hiding this comment.
For a better understanding of the frame, I think should declare ds with DataSource type.
louyuting
force-pushed
the
file-data-source
branch
from
7e03d5f to
2fff20e
Compare
louyuting
added
kind/feature
extension/property.go
Outdated
| realSrc, err := json.Marshal(realProperty) | ||
| if err!=nil { | ||
| logger.Warnf("Fail to marshal property source, err:%+v.", err) | ||
| } | ||
| isConsistent := h.isPropertyConsistent(realSrc) |
There was a problem hiding this comment.
Maybe we can compare the parsed entity directly, rather than convert it to JSON string then compare.
extension/property.go
Outdated
| type DefaultPropertyHandler struct { | ||
| lastUpdateProperty interface{} | ||
|
|
||
| Convert PropertyConvert |
There was a problem hiding this comment.
Make it private and access it with the getter method?
louyuting
force-pushed
the
file-data-source
branch
from
f6c1bcd to
d7d6a6c
Compare
|
Nice work. Thanks! |
4 participants
Describe what this PR does / why we need it
Does this pull request fix one issue?
Will define the dynamic data source extension framework.
Describe how you did it
Describe how to verify it
Special notes for reviews