Add support for collecting CPU usage for SystemRule #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Zhao <[email protected]>
louyuting
reviewed
Feb 21, 2020
core/system/sys_stat.go
Outdated
| } | ||
| } | ||
|
|
||
| func recordCpuUsage(prev, curCpuStat cpu.TimesStat) { |
Collaborator
There was a problem hiding this comment.
In order to avoid struct copy, it might be better to use Pointer instead of struct here?
Member
Author
There was a problem hiding this comment.
Good idea. I've updated the code and added a stat.system.collectIntervalMs conf item. Please check.
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
louyuting
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao [email protected]
Describe what this PR does / why we need it
Add support for collecting CPU usage for SystemRule.
Does this pull request fix one issue?
NONE
Describe how you did it
Calculate the CPU usage:
Describe how to verify it
Run the test cases and demo.
Special notes for reviews
NONE