Skip to content

Conversation

binbin0325
Copy link
Collaborator

@binbin0325 binbin0325 commented Jun 24, 2023

Describe what this PR does / why we need it

Does this pull request fix one issue?

fixed:#533 , #505

Describe how you did it

Describe how to verify it

Special notes for reviews

@binbin0325 binbin0325 force-pushed the master_fix_ci branch 2 times, most recently from d77790a to 6c9b71c Compare June 24, 2023 03:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0d804bb) 53.17% compared to head (1d4f136) 53.17%.

❗ Current head 1d4f136 differs from pull request most recent head a83caae. Consider uploading reports for the commit a83caae to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   53.17%   53.17%           
=======================================
  Files          91       91           
  Lines        5896     5894    -2     
=======================================
- Hits         3135     3134    -1     
+ Misses       2414     2413    -1     
  Partials      347      347           
Impacted Files Coverage Δ
api/init.go 0.00% <ø> (ø)
core/circuitbreaker/circuit_breaker.go 74.67% <ø> (ø)
core/circuitbreaker/rule_manager.go 76.40% <ø> (ø)
core/flow/tc_adaptive.go 45.45% <ø> (ø)
core/hotspot/rule_manager.go 57.53% <ø> (ø)
core/stat/base/leap_array.go 72.88% <ø> (ø)
core/system/rule_manager.go 76.47% <ø> (ø)
core/hotspot/rule.go 69.69% <100.00%> (+0.25%) ⬆️
core/stat/base/bucket_leap_array.go 65.57% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binbin0325 binbin0325 requested a review from sczyh30 June 24, 2023 04:52
Copy link
Collaborator Author

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and merge it first

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit ddd2642 into alibaba:master Jun 24, 2023
@sczyh30
Copy link
Member

sczyh30 commented Jun 24, 2023

Thanks!

binbin0325 added a commit to binbin0325/sentinel-golang that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants