MetricBucket reset #521
Merged
MetricBucket reset #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could you please reformat your code with |
binbin0325
reviewed
Mar 24, 2023
binbin0325
reviewed
Mar 30, 2023
|
@binbin0325 Is there something else wrong with my code now? Could you give me some suggestions for improvement or approve the review? |
|
@Alipebt Please merge submission records into one |
Signed-off-by: Alipebt <[email protected]>
|
@binbin0325 I have completed the merge of commit |
|
Thanks for contributing! |
binbin0325
pushed a commit
to binbin0325/sentinel-golang
that referenced
this pull request
Sep 18, 2024
Signed-off-by: Alipebt <[email protected]>
binbin0325
pushed a commit
to binbin0325/sentinel-golang
that referenced
this pull request
Sep 18, 2024
Signed-off-by: Alipebt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
the existing reset() function is not being used and a new MetricBucket is recreated in the ResetBucketTo() function. Therefore, we want to optimize our code to call reset() to avoid this unnecessary operation
Does this pull request fix one issue?
Fixes #403
Describe how you did it
add reset() to ResetBucketTo()
The addRT() mentioned in the issue is not thread-safe, I think we can lose some precision to ensure the efficient execution of the program, so I did not modify the function