Skip to content

Abstract concurrency-related operations as ConcurrencyStat interface and polish StatNode #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2020
Merged

Abstract concurrency-related operations as ConcurrencyStat interface and polish StatNode #283

merged 2 commits into from
Oct 15, 2020

Conversation

@louyuting
Copy link
Collaborator

@louyuting louyuting commented Oct 12, 2020

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@louyuting louyuting requested a review from sczyh30 October 12, 2020 12:56
@louyuting louyuting added the kind/enhancement Category issues or PRs related to enhancement label Oct 12, 2020
@louyuting louyuting added this to the 1.0.0 milestone Oct 12, 2020
@louyuting louyuting marked this pull request as ready for review October 13, 2020 02:51
luckyxiaoqiang
luckyxiaoqiang reviewed Oct 15, 2020
View reviewed changes
@louyuting louyuting force-pushed the 20201012-refine-StatNode branch from dbee9fc to d951f54 Compare October 15, 2020 14:21
@codecov-io
Copy link

codecov-io commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #283 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   51.30%   51.30%           
=======================================
  Files          79       79           
  Lines        4035     4035           
=======================================
  Hits         2070     2070           
  Misses       1676     1676           
  Partials      289      289
Impacted Files Coverage Δ
core/base/stat.go 78.57% <ø> (ø)
core/isolation/slot.go 0.00% <0.00%> (ø)
core/system/slot.go 54.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a6098c...d951f54. Read the comment docs.

sczyh30
sczyh30 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 changed the title Refine StatNode interface definition Abstract concurrency-related operations as ConcurrencyStat interface and polish StatNode Oct 15, 2020
@sczyh30 sczyh30 added kind/api-change Issues or PRs related to api changes kind/refactor Issue related to functional refactoring. labels Oct 15, 2020
@sczyh30 sczyh30 merged commit f1981c7 into alibaba:master Oct 15, 2020
@sczyh30
Copy link
Member

sczyh30 commented Oct 15, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luckyxiaoqiang luckyxiaoqiang luckyxiaoqiang left review comments

@sczyh30 sczyh30 sczyh30 approved these changes

Assignees

No one assigned

Labels

kind/api-change Issues or PRs related to api changes kind/enhancement Category issues or PRs related to enhancement kind/refactor Issue related to functional refactoring.

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@louyuting @codecov-io @sczyh30 @luckyxiaoqiang