Skip to content

Conversation

@sczyh30
Copy link
Member

@sczyh30 sczyh30 commented May 21, 2020

Signed-off-by: Eric Zhao [email protected]

Describe what this PR does / why we need it

Polish code of circuit breaker module.

Does this pull request fix one issue?

NONE

Describe how you did it

Improve comments, naming and logging of circuit breaker module.

Describe how to verify it

Run the test cases and demo.

Special notes for reviews

NONE

@sczyh30 sczyh30 added the kind/enhancement Category issues or PRs related to enhancement label May 21, 2020
@sczyh30 sczyh30 requested a review from louyuting May 21, 2020 15:12
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #152 into master will decrease coverage by 0.92%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   41.64%   40.71%   -0.93%     
==========================================
  Files          68       68              
  Lines        3314     3313       -1     
==========================================
- Hits         1380     1349      -31     
- Misses       1799     1828      +29     
- Partials      135      136       +1     
Impacted Files Coverage Δ
core/circuitbreaker/circuit_breaker.go 23.30% <0.00%> (ø)
core/circuitbreaker/stat_slot.go 0.00% <0.00%> (ø)
core/circuitbreaker/rule_manager.go 45.83% <20.00%> (-6.24%) ⬇️
core/circuitbreaker/rule.go 76.19% <33.33%> (-16.20%) ⬇️
core/flow/tc_throttling.go 66.66% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112f169...363557f. Read the comment docs.

Signed-off-by: Eric Zhao <[email protected]>
@sczyh30 sczyh30 force-pushed the polish-circuit-breaker-0521 branch from 4646454 to 363557f Compare May 22, 2020 01:41
@sczyh30 sczyh30 added the area/circuit-breaking Issues or PRs related to circuit breaking label May 22, 2020
@louyuting louyuting merged commit 2c544a8 into master May 22, 2020
@sczyh30 sczyh30 deleted the polish-circuit-breaker-0521 branch May 22, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/circuit-breaking Issues or PRs related to circuit breaking kind/enhancement Category issues or PRs related to enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants