Skip to content

remove unnecessary check for slidingWindowMetric.intervalInMs #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 20, 2020
Merged

remove unnecessary check for slidingWindowMetric.intervalInMs #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f25a2f0
make EntryOptions support storing custom data before Sentinel.Entry()
novoland Apr 10, 2020
e1be9ef
make data of SentinelInput / SentinelOutput public & rename to attach…
novoland Apr 10, 2020
f994aa8
remove unnecessary check for slidingWindowMetric.intervalInMs
novoland Apr 17, 2020
70fa47c
Merge remote-tracking branch 'ali/master'
novoland Apr 17, 2020
4294bab
Merge remote-tracking branch 'ali/master'
novoland Apr 17, 2020
648c6a4
add redundant test
novoland Apr 17, 2020
11c57b0
Merge branch 'master' of github.com:novoland/sentinel-golang
novoland Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions core/stat/base/sliding_window_metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,6 @@ func NewSlidingWindowMetric(sampleCount, intervalInMs uint32, real *BucketLeapAr
panic(fmt.Sprintf("The interval(%d) of SlidingWindowMetric is greater than parent BucketLeapArray(%d).", intervalInMs, parentIntervalInMs))
}

// 10 * 1000 ms == parent
if parentIntervalInMs%intervalInMs != 0 {
panic(fmt.Sprintf("SlidingWindowMetric's intervalInMs(%d) is not divisible by real BucketLeapArray's intervalInMs(%d).", intervalInMs, parentIntervalInMs))
}

return &SlidingWindowMetric{
bucketLengthInMs: bucketLengthInMs,
sampleCount: sampleCount,
Expand Down
9 changes: 0 additions & 9 deletions core/stat/base/sliding_window_metric_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,15 +163,6 @@ func Test_NewSlidingWindowMetric(t *testing.T) {
},
want: "The interval(200000) of SlidingWindowMetric is greater than parent BucketLeapArray(10000).",
},
{
name: "Test_NewSlidingWindowMetric-6",
args: args{
intervalInMs: 1500,
sampleCount: 3,
real: NewBucketLeapArray(SampleCount, IntervalInMs),
},
want: "SlidingWindowMetric's intervalInMs(1500) is not divisible by real BucketLeapArray's intervalInMs(10000).",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down