make EntryOptions support storing custom data before Sentinel.Entry() #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sczyh30
reviewed
Apr 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
- Coverage 43.38% 43.28% -0.11%
==========================================
Files 67 67
Lines 2828 2837 +9
==========================================
+ Hits 1227 1228 +1
- Misses 1463 1471 +8
Partials 138 138
Continue to review full report at Codecov.
|
|
Thanks for contributing! |
ansiz
pushed a commit
to ansiz/sentinel-golang
that referenced
this pull request
Dec 22, 2020
Support carrying additional attachments with sentinel.Entry(options) (alibaba#124) * make EntryOptions support carrying attachment data * make the `data` field of SentinelInput / SentinelOutput public and rename to `Attachments` Add MetricEventMonitorBlock Signed-off-by: Eric Zhao <[email protected]> Polish MetricItem with monitor-block metric event (alibaba#127) Sync special/metric-event branch with master (alibaba#136) * make EntryOptions support storing custom data before Sentinel.Entry() * make data of SentinelInput / SentinelOutput public & rename to attachment * remove unnecessary check for slidingWindowMetric.intervalInMs * Polish code of buildFlowMap in flow/rule_manager.go (alibaba#131) * Remove unnecessary division checking for interval of SlidingWindowMetric (alibaba#134) Co-authored-by: sdttttt <[email protected]> Add max concurrency statistic data (alibaba#138) Add support for getting max concurrency of the latest second (alibaba#140) feat: add SecondMaxConcurrency field to MetricItem (alibaba#145) feat: allow to disable metric log flush in runtime (alibaba#147)
sczyh30
pushed a commit
that referenced
this pull request
Dec 22, 2020
Support carrying additional attachments with sentinel.Entry(options) (#124) * make EntryOptions support carrying attachment data * make the `data` field of SentinelInput / SentinelOutput public and rename to `Attachments` Add MetricEventMonitorBlock Signed-off-by: Eric Zhao <[email protected]> Polish MetricItem with monitor-block metric event (#127) Sync special/metric-event branch with master (#136) * make EntryOptions support storing custom data before Sentinel.Entry() * make data of SentinelInput / SentinelOutput public & rename to attachment * remove unnecessary check for slidingWindowMetric.intervalInMs * Polish code of buildFlowMap in flow/rule_manager.go (#131) * Remove unnecessary division checking for interval of SlidingWindowMetric (#134) Co-authored-by: sdttttt <[email protected]> Add max concurrency statistic data (#138) Add support for getting max concurrency of the latest second (#140) feat: add SecondMaxConcurrency field to MetricItem (#145) feat: allow to disable metric log flush in runtime (#147)
sczyh30
pushed a commit
that referenced
this pull request
Dec 22, 2020
* sycn special branch commits Support carrying additional attachments with sentinel.Entry(options) (#124) * make EntryOptions support carrying attachment data * make the `data` field of SentinelInput / SentinelOutput public and rename to `Attachments` Add MetricEventMonitorBlock Signed-off-by: Eric Zhao <[email protected]> Polish MetricItem with monitor-block metric event (#127) Sync special/metric-event branch with master (#136) * make EntryOptions support storing custom data before Sentinel.Entry() * make data of SentinelInput / SentinelOutput public & rename to attachment * remove unnecessary check for slidingWindowMetric.intervalInMs * Polish code of buildFlowMap in flow/rule_manager.go (#131) * Remove unnecessary division checking for interval of SlidingWindowMetric (#134) Co-authored-by: sdttttt <[email protected]> Add max concurrency statistic data (#138) Add support for getting max concurrency of the latest second (#140) feat: add SecondMaxConcurrency field to MetricItem (#145) feat: allow to disable metric log flush in runtime (#147) * fix: fix broken test code * hotspot_rule_add_paramKey * concurrent processing(error group) for ExtractArgs Iteration * refmt * goimports Co-authored-by: Liu Jing <[email protected]> Co-authored-by: cafra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
We need to pass some data about current invocation to slots, while these data is parsed before
Sentinel.Entry().EntryOptionsis a suitable place but extra attribute is required.Does this pull request fix one issue?
None.
Describe how you did it
Add a map
data map[string]interface{}(and several functions associated) toEntryOptions.Describe how to verify it
Special notes for reviews