Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to translation key if not found in locale json #142

Closed

Conversation

zcoffin86
Copy link

@zcoffin86 zcoffin86 commented Sep 15, 2020

Mirror behavior of react-intl when key requested is not found in locale json.
#141

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cwtuan
Copy link
Collaborator

cwtuan commented Sep 16, 2020

Hi, @zcoffin86
Thanks for the contribution.
However, this PR may not be accepted since this change the behavior in current API.
We recommend use defaultMessage for every message in case that the key is not found.
For example, intl.get('HELLO', { name }).d(`Hello, ${name}`)
You could also add warningHandler in init function to accumulate missing messages using third party services.

@cwtuan cwtuan closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants