fix: segfault on Takesnapshot when go build -race #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash occurs because newproc1 is executed by the m0.g0 scheduling goroutine, which lacks racectx. However, contextPropagate inserted by -race forcibly adds a call to racefuncenter(), which expects racectx to be valid. Since m0.g0.racectx is 0, this leads to a crash.
One solution is to use the Go compiler's directive: