Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judge the message whether null for metadata processor. #9951

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Enhance the metadata operation stability. Handling the problem of when metadata operation throw an exception without message, the exception will be replaced by NPE and the statu machine will stop.

Brief changelog

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Feb 15, 2023
@KomachiSion KomachiSion added this to the 2.2.1 milestone Feb 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #9951 (9a13fbf) into develop (e736455) will increase coverage by 0.20%.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9951      +/-   ##
=============================================
+ Coverage      50.35%   50.56%   +0.20%     
- Complexity      4788     4830      +42     
=============================================
  Files            861      861              
  Lines          27441    27445       +4     
  Branches        3028     3031       +3     
=============================================
+ Hits           13818    13877      +59     
+ Misses         12410    12351      -59     
- Partials        1213     1217       +4     
Impacted Files Coverage Δ
...ng/core/v2/metadata/InstanceMetadataProcessor.java 0.00% <0.00%> (ø)
...ing/core/v2/metadata/ServiceMetadataProcessor.java 69.35% <0.00%> (-1.14%) ⬇️
...naming/core/v2/metadata/NamingMetadataManager.java 78.75% <50.00%> (-1.00%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 55.59% <0.00%> (-0.20%) ⬇️
.../core/v2/event/publisher/NamingEventPublisher.java 75.94% <0.00%> (+1.26%) ⬆️
...os/client/auth/ram/identify/CredentialService.java 76.08% <0.00%> (+4.34%) ⬆️
.../nacos/api/config/ability/ServerConfigAbility.java 54.54% <0.00%> (+54.54%) ⬆️
...com/alibaba/nacos/api/ability/ServerAbilities.java 90.47% <0.00%> (+90.47%) ⬆️
...com/alibaba/nacos/api/ability/ClientAbilities.java 100.00% <0.00%> (+100.00%) ⬆️
.../nacos/api/config/ability/ClientConfigAbility.java 100.00% <0.00%> (+100.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e736455...9a13fbf. Read the comment docs.

@KomachiSion KomachiSion merged commit 9ebf5ae into alibaba:develop Feb 15, 2023
@KomachiSion KomachiSion deleted the enhance-metadata-raft-stability branch February 15, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants