Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #974] ArrayIndexOutOfBoundsException may be thrown when invokes taskDispatcher.addTask #975

Merged
merged 7 commits into from
Apr 1, 2019

Conversation

jifengnan
Copy link
Contributor

@jifengnan jifengnan commented Mar 29, 2019

What is the purpose of the change

Fixes #974 .

Brief changelog

加了一个新的通用的方法,解决Math.abs(Integer.MIN_VALUE)返回值为负数的问题。
Added a new util method to solve the issue that the return value of Math.abs may be negative.

Verifying this change

A unit test is added on TaskDispatcherTest.testAddTask, it works well now if the hashcode is Integer.MIN_VALUE

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@nkorange nkorange changed the base branch from master to develop April 1, 2019 02:44
@nkorange nkorange merged commit b1790fa into alibaba:develop Apr 1, 2019
@nkorange
Copy link
Collaborator

nkorange commented Apr 1, 2019

Thanks for your contribution. Next time point to alibaba:develop please :)

@jifengnan
Copy link
Contributor Author

@nkorange Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants