Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth for some v2 api. #9671

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added this to the 2.2.0 milestone Dec 7, 2022
@KomachiSion KomachiSion closed this Dec 7, 2022
@KomachiSion KomachiSion reopened this Dec 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9671 (e6bf27b) into develop (528574d) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9671      +/-   ##
=============================================
+ Coverage      47.32%   47.34%   +0.01%     
- Complexity      4481     4482       +1     
=============================================
  Files            852      852              
  Lines          27781    27782       +1     
  Branches        3092     3093       +1     
=============================================
+ Hits           13148    13152       +4     
+ Misses         13456    13452       -4     
- Partials        1177     1178       +1     
Impacted Files Coverage Δ
.../nacos/core/controller/v2/CoreOpsV2Controller.java 100.00% <ø> (ø)
...s/core/controller/v2/NacosClusterControllerV2.java 52.63% <ø> (ø)
.../naming/controllers/v2/ClientInfoControllerV2.java 0.00% <0.00%> (ø)
...s/console/controller/v2/NamespaceControllerV2.java 73.91% <100.00%> (+1.18%) ⬆️
...os/client/auth/ram/identify/CredentialService.java 71.73% <0.00%> (-4.35%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 51.35% <0.00%> (+0.19%) ⬆️
...ent/manager/impl/ConnectionBasedClientManager.java 81.13% <0.00%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528574d...e6bf27b. Read the comment docs.

@onewe onewe merged commit dfcdd39 into alibaba:develop Dec 8, 2022
@KomachiSion KomachiSion deleted the develop-2.0-api-auth branch December 13, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants