Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9615] fixed the issue of client get same server #9616

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

chengyj1986xxx
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix issue #9615

Brief changelog

fixed the issue of client get same server

Verifying this change

After modification, the client will get a random server.
修改后客户端将获得随机的server地址。
image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2022

CLA assistant check
All committers have signed the CLA.

@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Nov 22, 2022
@KomachiSion KomachiSion added this to the 2.2.0 milestone Nov 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9616 (3663d7d) into develop (ba37d63) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9616      +/-   ##
=============================================
- Coverage      47.76%   47.60%   -0.16%     
+ Complexity      4580     4577       -3     
=============================================
  Files            855      855              
  Lines          28358    28358              
  Branches        3199     3199              
=============================================
- Hits           13544    13499      -45     
- Misses         13583    13628      +45     
  Partials        1231     1231              
Impacted Files Coverage Δ
...ient/naming/remote/http/NamingHttpClientProxy.java 81.81% <100.00%> (ø)
...a/com/alibaba/nacos/core/remote/BaseRpcServer.java 63.15% <0.00%> (-26.32%) ⬇️
...ent/manager/impl/EphemeralIpPortClientManager.java 66.66% <0.00%> (-14.82%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 50.77% <0.00%> (-4.64%) ⬇️
...m/alibaba/nacos/core/remote/ConnectionManager.java 44.37% <0.00%> (-1.48%) ⬇️
...cos/core/cluster/remote/ClusterRpcClientProxy.java 72.85% <0.00%> (-1.43%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 53.50% <0.00%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba37d63...3663d7d. Read the comment docs.

@KomachiSion KomachiSion merged commit f36e8db into alibaba:develop Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants