Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#8650] Make cluster/report both receive and send metadata. #9228

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fixes #8650 .

Brief changelog

  • cluster/report api return self information.
  • Update metadata when received report response.
  • Add UT.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/feature type/feature label Sep 28, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Sep 28, 2022
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. and removed kind/feature type/feature labels Sep 28, 2022
@KomachiSion KomachiSion changed the title Develop issue#8650 [ISSUE#8650] Make cluster/report both receive and send metadata. Sep 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9228 (962bd47) into develop (04fe7ea) will increase coverage by 0.25%.
The diff coverage is 72.41%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9228      +/-   ##
=============================================
+ Coverage      43.81%   44.06%   +0.25%     
- Complexity      4839     4857      +18     
=============================================
  Files            913      913              
  Lines          33030    33043      +13     
  Branches        3826     3825       -1     
=============================================
+ Hits           14472    14562      +90     
+ Misses         17141    17061      -80     
- Partials        1417     1420       +3     
Impacted Files Coverage Δ
...libaba/nacos/core/cluster/ServerMemberManager.java 72.17% <64.28%> (+18.04%) ⬆️
...ava/com/alibaba/nacos/core/cluster/MemberUtil.java 96.00% <92.30%> (+22.26%) ⬆️
...on/remote/client/grpc/DefaultGrpcClientConfig.java 40.83% <100.00%> (ø)
.../nacos/core/controller/NacosClusterController.java 72.41% <100.00%> (ø)
...ibaba/nacos/core/cluster/MemberChangeListener.java 66.66% <0.00%> (-33.34%) ⬇️
...alibaba/nacos/core/cluster/MembersChangeEvent.java 66.66% <0.00%> (-5.56%) ⬇️
...m/alibaba/nacos/core/remote/ConnectionManager.java 42.89% <0.00%> (-1.48%) ⬇️
...baba/nacos/naming/healthcheck/HealthCheckTask.java 45.58% <0.00%> (ø)
...a/nacos/core/remote/control/TpsMonitorManager.java 54.77% <0.00%> (+1.27%) ⬆️
...nacos/naming/core/v2/upgrade/UpgradeJudgement.java 80.00% <0.00%> (+2.60%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fe7ea...962bd47. Read the comment docs.

@chuntaojun chuntaojun merged commit 45165f7 into alibaba:develop Sep 28, 2022
@KomachiSion KomachiSion deleted the develop-issue#8650 branch September 29, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.1.x] Make cluster/report both receive and send metadata
3 participants