Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8434] enhance DistroConsistencyServiceImpl listen/unListen #8435

Merged
merged 1 commit into from
May 23, 2022
Merged

[ISSUE #8434] enhance DistroConsistencyServiceImpl listen/unListen #8435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions ...a/com/alibaba/nacos/naming/consistency/ephemeral/distro/DistroConsistencyServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,26 +322,36 @@ public boolean processSnapshot(DistroData distroData) {

@Override
public void listen(String key, RecordListener listener) throws NacosException {
if (!listeners.containsKey(key)) {
listeners.put(key, new ConcurrentLinkedQueue<>());
ConcurrentLinkedQueue<RecordListener> recordListeners = listeners.get(key);
if (recordListeners == null) {
recordListeners = new ConcurrentLinkedQueue<>();
ConcurrentLinkedQueue<RecordListener> recordListenersExist;
if ((recordListenersExist = listeners.putIfAbsent(key, recordListeners)) != null) {
recordListeners = recordListenersExist;
}
}

if (listeners.get(key).contains(listener)) {
return;

if (!recordListeners.contains(listener)) {
synchronized (recordListeners) {
if (!recordListeners.contains(listener)) {
recordListeners.add(listener);
}
}
}

listeners.get(key).add(listener);
}

@Override
public void unListen(String key, RecordListener listener) throws NacosException {
if (!listeners.containsKey(key)) {
ConcurrentLinkedQueue<RecordListener> recordListeners = listeners.get(key);
if (recordListeners == null) {
return;
}
for (RecordListener recordListener : listeners.get(key)) {
if (recordListener.equals(listener)) {
listeners.get(key).remove(listener);
break;
synchronized (recordListeners) {
for (RecordListener recordListener : recordListeners) {
if (recordListener.equals(listener)) {
recordListeners.remove(listener);
break;
}
}
}
}
Expand Down