issue#8163 fix multi instance share the same local snapshot #8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shiyiyue1102
changed the title
shiyiyue1102
changed the title
…ies to control whether load snaoshot content on startup in CacheData
shiyiyue1102
force-pushed
the
develop-issue#8163
branch
from
ce94aa5 to
8294673
Compare
shiyiyue1102
changed the title
| @@ -132,28 +132,28 @@ public ServerListManager(List<String> fixed, String namespace) { | |||
| for (String serverAddr : fixed) { | |||
| String[] serverAddrArr = InternetAddressUtil.splitIPPortStr(serverAddr); | |||
| if (serverAddrArr.length == 1) { | |||
| serverAddrs.add(serverAddrArr[0] + InternetAddressUtil.IP_PORT_SPLITER + ParamUtil.getDefaultServerPort()); | |||
| serverAddrs | |||
There was a problem hiding this comment.
I don't think this change is necessary
There was a problem hiding this comment.
the modification on ServerListManager has several purposes:
1.optimize the naming rule of server name when the serverlistmanager is using endpoint , port,contentpath ,cluster name which construct the whole address server.
2.support endpoint query string parameter after the address server url to satisfy more usage scenarios , for example, this query string is essential in alibaba internal scene when using address server.
3.support user defined server name to serverlistmanager and client worker , to make our log print more graceful in multi instances scenarios.
li-xiao-shuang
approved these changes
Apr 24, 2022
KomachiSion
added
area/Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug isuue #8163
add nacos.cache.data.init.snapshot properties ,to determine if load snapshot content on startup which will result in a default notification on initialing ,default is true