-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-#4567] Refactor nacos-client Load Logging Configuration code. #4572
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
57965d8
for #4567, refactor nacos-client logging load Configuration code.
Maijh97 2d49c20
Modify exception handling.
Maijh97 a95f024
When customizing AbstractNacosLogging Load Configuration Fail, use th…
Maijh97 17069ce
NacosLogging has been modified to a single-column mode.
Maijh97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
70 changes: 70 additions & 0 deletions
70
client/src/main/java/com/alibaba/nacos/client/logging/NacosLogging.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright 1999-2018 Alibaba Group Holding Ltd. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.alibaba.nacos.client.logging; | ||
|
||
import com.alibaba.nacos.client.logging.log4j2.Log4J2NacosLogging; | ||
import com.alibaba.nacos.client.logging.logback.LogbackNacosLogging; | ||
import org.slf4j.LoggerFactory; | ||
import org.slf4j.Logger; | ||
|
||
/** | ||
* nacos logging. | ||
* | ||
* @author mai.jh | ||
*/ | ||
public class NacosLogging { | ||
|
||
private static final Logger LOGGER = LoggerFactory.getLogger(NacosLogging.class); | ||
|
||
private AbstractNacosLogging nacosLogging; | ||
|
||
private boolean isLogback = false; | ||
|
||
private NacosLogging() { | ||
try { | ||
Class.forName("ch.qos.logback.classic.Logger"); | ||
nacosLogging = new LogbackNacosLogging(); | ||
isLogback = true; | ||
} catch (ClassNotFoundException e) { | ||
nacosLogging = new Log4J2NacosLogging(); | ||
} | ||
} | ||
|
||
private static class NacosLoggingInstance { | ||
|
||
private static final NacosLogging INSTANCE = new NacosLogging(); | ||
} | ||
|
||
public static NacosLogging getInstance() { | ||
return NacosLoggingInstance.INSTANCE; | ||
} | ||
|
||
/** | ||
* Load logging Configuration. | ||
*/ | ||
public void loadConfiguration() { | ||
try { | ||
nacosLogging.loadConfiguration(); | ||
} catch (Throwable t) { | ||
if (isLogback) { | ||
LOGGER.warn("Load Logback Configuration of Nacos fail, message: {}", t.getMessage()); | ||
} else { | ||
LOGGER.warn("Load Log4j Configuration of Nacos fail, message: {}", t.getMessage()); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个变量感觉好绕啊。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是单例模式+策略模式的实现,对外其实只暴露了这一个方法,内部具体是logback还是log4j2是在初始化的时候决定的。
暂时没有开放完全拓展,主要是两个考虑, 一方面是nacos的日志主要是给运维人员排查用,不希望业务人员随意的改动nacos日志输出的级别和内容,另一方面日志框架其实并不太多,不会频繁扩展,适配起来难度不高。
将来如果需要完全拓展, 初始化加载的时候用个SPI就可以了。