Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3515] upgrade spring-boot-dependencies version to 2.1.16.RELE… #3563

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

corey89757
Copy link
Contributor

What is the purpose of the change

#3515

Brief changelog

upgrade spring-boot-dependencies version to 2.1.16.RELEASE, tomcat-embed-jasper version to 9.0.37

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…16.RELEASE, tomcat-embed-jasper version to 9.0.37

Change-Id: I021396ae0b75fc889f087c4a4c253549ad46b46f
@corey89757
Copy link
Contributor Author

@zongtanghu please review this pull request.

@zongtanghu
Copy link
Collaborator

Serveral things are need to be checked:
(1).Check the nacos's funtions is ok, including standalone mode and cluster mode in your local enviroments.
(2).Check the reason why the nacos' ci tests failed?

@corey89757

@corey89757
Copy link
Contributor Author

1.I've already run cluster mode server in my local environments, run both ConfigExample and NamingExample, checked the console display.
2.It's a ci test bug. Maybe create a issue later.

@KomachiSion
Copy link
Collaborator

@zongtanghu Can you double check this upgrade ?

@zongtanghu
Copy link
Collaborator

@zongtanghu Can you double check this upgrade ?

Okay, we will double check this upgrade.

@KomachiSion KomachiSion added this to the 1.4.0 milestone Aug 12, 2020
@KomachiSion KomachiSion merged commit 6607a1e into alibaba:develop Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants