Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3353]Adjust the value logic of clientBeatInterval #3377

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

wangweizZZ
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#3353

Brief changelog

Adjust the value logic of clientBeatInterval

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@@ -211,6 +211,10 @@ private static boolean strEquals(final String str1, final String str2) {
return str1 == null ? str2 == null : str1.equals(str2);
}

public Long getInstanceHeartBeatIntervalNullable() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this too complicated?
I think one containMetaData is more simple, readable and versatile.

@wangweizZZ
Copy link
Collaborator Author

@KomachiSion Please help to review this change, thanks.

@KomachiSion KomachiSion merged commit 75dfd10 into alibaba:develop Jul 20, 2020
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Naming labels Jul 20, 2020
@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Naming kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants