Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server side connection listener ,and add client version #3350

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@shiyiyue1102 shiyiyue1102 force-pushed the feature_nacos_support_grpc_20200714 branch from 7b3f6c5 to ceab1c0 Compare July 16, 2020 07:59
@shiyiyue1102 shiyiyue1102 changed the base branch from develop to feature_support_grpc_core July 16, 2020 08:00
@zongtanghu
Copy link
Collaborator

GPRC通信层相关的一些内容,是否再独立放在一个比如叫rpc-grpc-impl的module里面? @KomachiSion @shiyiyue1102

@KomachiSion
Copy link
Collaborator

KomachiSion commented Jul 16, 2020

GPRC通信层相关的一些内容,是否再独立放在一个比如叫rpc-grpc-impl的module里面? @KomachiSion @shiyiyue1102

最后会拆开,目前先丢一起吧

@KomachiSion KomachiSion added this to the 1.4.0 milestone Jul 16, 2020
… ,base on heart beat expire time check 2.add client version info after grpc connection build
@shiyiyue1102 shiyiyue1102 force-pushed the feature_nacos_support_grpc_20200714 branch from e1b8786 to 636f114 Compare July 16, 2020 11:20
@KomachiSion KomachiSion merged commit b10a248 into alibaba:feature_support_grpc_core Jul 16, 2020
@KomachiSion KomachiSion modified the milestones: 1.4.0, 2.0.0 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants